[Laravel Preset] Allow App\Http to be used in providers#1639
Open
imliam wants to merge 1 commit intopestphp:4.xfrom
Open
[Laravel Preset] Allow App\Http to be used in providers#1639imliam wants to merge 1 commit intopestphp:4.xfrom
imliam wants to merge 1 commit intopestphp:4.xfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
Description:
There are scenarios where a Laravel application may legitimately reference classes from the
App\Httpnamespace outside itself, for example:Even if neither of these are scenarios a vanilla Laravel application will run into, I believe Filament is a big enough package in the ecosystem to warrant having good preset support out of the box (especially as we can't undo individual rules in the preset)